Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove diagnostic category flag #74352

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

CyrusNajmabadi
Copy link
Member

This flag was never read. Removing in the hopes of getting to the point that we can make this API public.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner July 11, 2024 15:34
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 11, 2024
{
var category = analyzer.GetDiagnosticAnalyzerCategory();
return (category & DiagnosticAnalyzerCategory.ProjectAnalysis) != 0;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method was never called. so nothing ever actually checked if hte .ProjectAnalysis flag was set for an analyzer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants